Fleet Allocation via REST was failing #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST api wasn't populating the metadata.namespace whereas the kubectl command will when sending yaml - which caused an issue when attempting to Fleet Allocate via REST. We now pull the namespace from the AdmissionReview, which solves this problem. Also documented the workaround as well. Closes googleforgames#324
markmandel
added
kind/bug
|
/cc @KamiShepard FYI |
|
Build Succeeded 👏 Build Id: 7c0583bd-2269-4d1d-b06c-12c7b5e005d1 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST api wasn't populating the metadata.namespace whereas the kubectl command will when sending yaml - which caused an issue when attempting to Fleet Allocate via REST.
We now pull the namespace from the AdmissionReview, which solves this problem.
Also documented the workaround as well.
Closes #324