Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do-release release registry and upstream push #228

Merged
merged 2 commits into from
May 26, 2018
Merged

do-release release registry and upstream push #228

merged 2 commits into from
May 26, 2018

Conversation

markmandel
Copy link
Member

This PR does two things:

  1. Ensure the built images always have the release registry
  2. Ensure the release branch is pushed to upstream, rather than to a forked origin.

@markmandel
do-release release registry and upstream push
7afa3cd 
This PR does two things:
1) Ensure the built images always have the release
 registry
2) Ensure the release branch is pushed to upstream,
 rather than to a forked origin.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels May 25, 2018
@markmandel markmandel added this to the 0.2.0 milestone May 25, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 658dd7bb-652a-41c6-b6b9-aa2c06555701

The following development artifacts have been built, and will exist for the next 30 days:

cyriltovena
cyriltovena reviewed May 26, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upstream the default git remote name for upstream or your own convention? Mine is upstream but I named it this way :p
Edit: looked up online it's the default

@markmandel
Copy link
Member Author

That's a good question - I've just been using upstream for years since I probably read it somewhere on the internet that is was a thing 😄

Looks like github also has the same thing - https://help.github.com/articles/configuring-a-remote-for-a-fork/

Is it actually part of some tooling that sets it up that way as well?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7d86a6ca-d2e4-4756-8ffa-c45f00b4b208

The following development artifacts have been built, and will exist for the next 30 days:

@markmandel markmandel merged commit 675dddd into googleforgames:master May 26, 2018
@markmandel markmandel deleted the cleanup/do-release branch May 26, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena