Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve rare flakiness on TestWorkerQueueHealthy #185

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Solve rare flakiness on TestWorkerQueueHealthy #185

merged 1 commit into from
Apr 23, 2018

Conversation

markmandel
Copy link
Member

Every so often, this test would fail me locally.

This should fix things!

@markmandel
Solve rare flakiness on TestWorkerQueueHealthy
44eb00d 
Every so often, this test would fail me locally.

This should fix things!
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 23, 2018
@markmandel markmandel added this to the 0.2 milestone Apr 23, 2018
@markmandel markmandel requested a review from enocom April 23, 2018 21:48
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 043f7b91-0690-4cdb-9371-ef62f2c6f5bf

The following development artifacts have been built, and will exist for the next 30 days:

enocom
enocom approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing the scheduler to run another goroutine is tricky business. This looks like an improvement.

@enocom enocom merged commit cfe8fae into googleforgames:master Apr 23, 2018
@markmandel markmandel deleted the cleanup/wq-healthy-test branch April 23, 2018 22:39
@markmandel markmandel mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @enocom