Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As game server, I want to get the Agones sidecar version #310

Closed
victor-prodan opened this issue Jul 30, 2018 · 3 comments
Closed

As game server, I want to get the Agones sidecar version #310

victor-prodan opened this issue Jul 30, 2018 · 3 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone
0.8.0

Comments

@victor-prodan
Copy link
Contributor

Useful mainly for logging, to know with what version of Agones sidecar you're running.
But game servers could also require a minimum (or a specific) version to run.

Maybe add it as an annotation?
@markmandel
Copy link
Member

markmandel commented Jul 30, 2018 •
edited
Loading

The Agones sidecar does send its version to its own log stream, which will get added to the logs for the Pod, so it should be there already.

But I like the idea of adding the Agones version to a GameServer (and maybe all resources?) as an annotation. Could be useful as upgrades happen. 👍 I can see that being useful.

@jkowalski jkowalski mentioned this issue Dec 22, 2018
Closed
@markmandel markmandel added kind/feature New features for Agones kind/design Proposal discussing new features / fixes and how they should be implemented good first issue These are great first issues. If you are looking for a place to start, start here! labels Jan 16, 2019
@aLekSer aLekSer mentioned this issue Jan 23, 2019
Merged
@aLekSer
Copy link
Collaborator

aLekSer commented Jan 23, 2019

In this PR I added annotation into Gameserver CRD and Pod Annotations as well as Fleet Annotation.
Other CRDs like Fleetautoscaler and Gameserverset does not contain creationMutationHandler so we can skip them for now.

@markmandel
Copy link
Member

@aLekSer , @victor-prodan I assume we can close this now, due to #498 ?

@markmandel markmandel added this to the 0.8.0 milestone Jan 30, 2019
@WontonSam WontonSam mentioned this issue Nov 29, 2023
Open
@WontonSam WontonSam mentioned this issue Jan 2, 2024
Open
@WontonSam WontonSam mentioned this issue Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@markmandel @aLekSer @victor-prodan