Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check for the Controller #11

Closed
markmandel opened this issue Dec 7, 2017 · 1 comment
Closed

Health Check for the Controller #11

markmandel opened this issue Dec 7, 2017 · 1 comment
Assignees
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone

Comments

@markmandel
Copy link
Member

markmandel commented Dec 7, 2017

The controller currently needs a liveness http check, and a restart if it fails.

So we'll need to add a /healthz HTTP handler somewhere in:
https://github.com/googleprivate/agon/blob/master/gameservers/controller/controller.go

I expect we'll likely need to run the http server in it's own go-routine / manage how shutdown will occur in a somewhat graceful way.

And update the install.yaml (in both root and build directories) to include the new liveness check

References:
Go net/http package

@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones labels Dec 7, 2017
@markmandel
Copy link
Member Author

Closed in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

2 participants