Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gopkg.toml should use tags not branches for k8s.io dependencies #1

Closed
markmandel opened this issue Dec 7, 2017 · 0 comments
Closed

Gopkg.toml should use tags not branches for k8s.io dependencies #1

markmandel opened this issue Dec 7, 2017 · 0 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
0.1

Comments

@markmandel
Copy link
Member

markmandel commented Dec 7, 2017 •
edited
Loading

See: https://github.com/googleprivate/agon/blob/master/Gopkg.toml#L27-L33

Switch to using all release branches (which is just client-go that needs to change) Technically using a mixture of tags and branches is not supported (although it does seem to work).

Also, code-generator now has vendored dependencies - we can fix the Dockerfile as well and not run codegen from HEAD. e.g. https://github.com/kubernetes/code-generator/tree/release-1.8

More context see PR: kubernetes/client-go#337
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 7, 2017
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Updaate to relese branches.
fb95e3f 
Closes #1
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Update Kubernetes dependencies to release branch
bf80a02 
Move the dependency toml to all use the release branches
of the Kubernetes libraries.

Also changes the build image to use the release-1.8 branch
of the code-generator Kuebrnetes repository, now that
it hsa vendored dependencies.

Closes #1
@markmandel markmandel mentioned this issue Dec 13, 2017
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
@markmandel markmandel mentioned this issue Jul 19, 2018
Closed
markmandel referenced this issue in markmandel/agones Aug 9, 2018
@markmandel
Step #1 - events are now propogating from the sidecar.
85c0c48 
TODO: remove the unhealthy in the yaml.
markmandel referenced this issue in markmandel/agones Aug 10, 2018
@markmandel
Step #1 - events are now propogating from the sidecar.
57e4538 
TODO: remove the unhealthy in the yaml.
@markmandel markmandel mentioned this issue Sep 1, 2018
Closed
markmandel referenced this issue in markmandel/agones Oct 4, 2018
@markmandel
Attempt #1
b912562
@akremsa akremsa mentioned this issue Apr 9, 2020
Merged
@satishdsb satishdsb mentioned this issue Sep 21, 2022
Closed
@Kalaiselvi84 Kalaiselvi84 mentioned this issue Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel