chore(flakiness): Flakiness Dashboard fixes #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix `FLAKINESS_DASHBOARD_BUILD_URL` to point to a task instead of a build - do not pretty-print `dashboard.json` when serializing flakiness results.
MedRedha
approved these changes
Aug 1, 2019
MedRedha
approved these changes
Aug 1, 2019
JoelEinbinder
approved these changes
Aug 1, 2019
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
- fix `FLAKINESS_DASHBOARD_BUILD_URL` to point to a task instead of a build - do not pretty-print `dashboard.json` when serializing flakiness results - filter out 'COVERAGE' test(s) so that they don't add up to `dashboard.json` payload. These are useless - validate certain important options of flakiness dashboard - more logging to STDOUT to actually say which repo and what branch is getting used - enhance commit message with a build URL - use a more compact format for JSON. For 100 runs of 700 tests it yields 21MB json instead of 23MB. - bump default builds number to 100
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLAKINESS_DASHBOARD_BUILD_URLto point to a task instead of a builddashboard.jsonwhen serializing flakiness resultsdashboard.jsonpayload. These are useless