Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coverage): fix coverage for events #4787

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Aug 1, 2019

We used to track API Coverage for public events, but this was regressed in the refactoring that
introduced //lib/Events.js.

This patch:

  • Brings back API Coverage for events
  • Combines all coverage-generated tests into a single one. This way
    we can generate less data for flakiness dashboard.

- Bring back API Coverage for events
- Combine all coverage-generated tests into a single one. This way
we can generate less data for flakiness dashboard.
@aslushnikov aslushnikov merged commit 5c7c45f into puppeteer:master Aug 1, 2019
@aslushnikov aslushnikov deleted the fix-coverage branch August 1, 2019 23:09
rfojtik pushed a commit to rfojtik/puppeteer that referenced this pull request Dec 21, 2019
We used to track API Coverage for public events, but this was regressed in the refactoring that
introduced `//lib/Events.js`.

This patch:
- Brings back API Coverage for events
- Combines all coverage-generated tests into a single one. This way
we can generate less data for flakiness dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants