Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): make dumpio and pipe options work together #4727

Merged
merged 5 commits into from
Jul 18, 2019

Conversation

yury-s
Copy link
Contributor

@yury-s yury-s commented Jul 18, 2019

Don't ignore stdout and stderr when using pipe for remote debugging and dumpio is true. In that case puppeteer process connects to the stdout/stderr streams of the child process and it will not hang.

@yury-s yury-s changed the title Make dumpio and pipe options work together fix(launcher): make dumpio and pipe options work together Jul 18, 2019
@aslushnikov
Copy link
Contributor

@yury-s
Copy link
Contributor Author

yury-s commented Jul 18, 2019

Let's add a test!

@aslushnikov Done. I was originally inspired by testing approach from 14e69d1 :)

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aslushnikov aslushnikov merged commit 2abaac1 into puppeteer:master Jul 18, 2019
@yury-s yury-s deleted the pipe-dumpio branch July 19, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants