fix(page): properly create isolated worlds #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error: ``` Error: Protocol error (Page.createIsolatedWorld): No frame for given id found ``` was mentioned here: FlowCrypt/flowcrypt-browser#1799 (comment) This indeed seems to be a bug with our creation of isolated worlds.
lib/FrameManager.js
Outdated
| @@ -276,7 +276,7 @@ class FrameManager extends EventEmitter { | |||
| frameId: frame._id, | |||
| grantUniveralAccess: true, | |||
| worldName: name, | |||
| }))); | |||
| }).catch(debugError))); | |||
There was a problem hiding this comment.
comment why this can fail. Frames die while we are creating worlds in them?
There was a problem hiding this comment.
Yes, that's the pattern we already use in code.
JoelEinbinder
approved these changes
Jul 16, 2019
JoelEinbinder
approved these changes
Jul 16, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error:
was mentioned here:
FlowCrypt/flowcrypt-browser#1799 (comment)
This indeed seems to be a bug with our creation of isolated worlds.