Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): jshandle test fix #4698

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Conversation

yury-s
Copy link
Contributor

@yury-s yury-s commented Jul 12, 2019

Check message prefix rather than strict equality when detecting circular JSON error. The message format has changed recently which broke the condition.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aslushnikov
Copy link
Contributor

The message format has changed recently which broke the condition.

In Node 12 I guess. I'll add Node 10 and Node 12 bots to catch this kind of regressions

@aslushnikov aslushnikov merged commit 715aad2 into puppeteer:master Jul 13, 2019
@yury-s yury-s deleted the test-fix branch July 19, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants