From 91a873bcf30ff46fb767061e92a16c4621996f33 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Wed, 10 Jul 2019 09:41:32 -0500 Subject: [PATCH 1/2] deps: update axe-core to 3.3.0 --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 1b6e5bc1c715..ff2e0f64de77 100644 --- a/package.json +++ b/package.json @@ -137,7 +137,7 @@ "zone.js": "^0.7.3" }, "dependencies": { - "axe-core": "3.2.2", + "axe-core": "3.3.0", "chrome-launcher": "^0.10.7", "configstore": "^3.1.1", "cssstyle": "1.2.1", diff --git a/yarn.lock b/yarn.lock index d18514554fc3..e2dbada360eb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1135,10 +1135,10 @@ aws4@^1.8.0: resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f" integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ== -axe-core@3.2.2: - version "3.2.2" - resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-3.2.2.tgz#b06d6e9ae4636d706068843272bfaeed3fe97362" - integrity sha512-gAy4kMSPpuRJV3mwictJqlg5LhE84Vw2CydKdC4tvrLhR6+G3KW51zbL/vYujcLA2jvWOq3HMHrVeNuw+mrLVA== +axe-core@3.3.0: + version "3.3.0" + resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-3.3.0.tgz#3b32d7e54390d89ff4891b20394d33ad7a192776" + integrity sha512-54XaTd2VB7A6iBnXMUG2LnBOI7aRbnrVxC5Tz+rVUwYl9MX/cIJc/Ll32YUoFIE/e9UKWMZoQenQu9dFrQyZCg== axios@0.15.3: version "0.15.3" From f45ae9e1ac2f552f3b446c03f74a9a72ea81b5d8 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Wed, 10 Jul 2019 14:30:28 -0500 Subject: [PATCH 2/2] fixes --- lighthouse-cli/test/smokehouse/a11y/expectations.js | 2 +- lighthouse-core/gather/gatherers/accessibility.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lighthouse-cli/test/smokehouse/a11y/expectations.js b/lighthouse-cli/test/smokehouse/a11y/expectations.js index 9f29e47c349b..214b4fee2170 100644 --- a/lighthouse-cli/test/smokehouse/a11y/expectations.js +++ b/lighthouse-cli/test/smokehouse/a11y/expectations.js @@ -121,7 +121,7 @@ module.exports = [ 'type': 'node', 'selector': '#button-name', 'snippet': '', - 'explanation': 'Fix all of the following:\n Element is in tab order and does not have accessible text\n\nFix any of the following:\n Element has a value attribute and the value attribute is empty\n Element has no value attribute or the value attribute is empty\n Element does not have inner text that is visible to screen readers\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty\n Element\'s default semantics were not overridden with role="presentation"\n Element\'s default semantics were not overridden with role="none"\n Element has no title attribute or the title attribute is empty', + 'explanation': 'Fix any of the following:\n Element does not have inner text that is visible to screen readers\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty\n Element\'s default semantics were not overridden with role="presentation"\n Element\'s default semantics were not overridden with role="none"\n Element has no title attribute or the title attribute is empty', 'nodeLabel': 'button', }, }, diff --git a/lighthouse-core/gather/gatherers/accessibility.js b/lighthouse-core/gather/gatherers/accessibility.js index d8cbcb655651..e4aa8b491e86 100644 --- a/lighthouse-core/gather/gatherers/accessibility.js +++ b/lighthouse-core/gather/gatherers/accessibility.js @@ -47,6 +47,8 @@ function runA11yChecks() { 'server-side-image-map': {enabled: false}, 'aria-hidden-focus': {enabled: false}, 'form-field-multiple-labels': {enabled: false}, + 'aria-input-field-name': {enabled: false}, + 'aria-toggle-field-name': {enabled: false}, }, // @ts-ignore }).then(axeResult => {