From 0ff259d13298094d9323788c0bbef35cb83c26b0 Mon Sep 17 00:00:00 2001
From: Connor Clark <cjamcl@google.com>
Date: Thu, 4 Jan 2024 15:13:42 -0800
Subject: [PATCH] core(layout-shift-elements): hide audit

---
 core/config/default-config.js                 |  2 +-
 .../reports/sample-flow-result.json           | 27 ++++++++++---------
 core/test/results/sample_v2.json              |  9 ++++---
 .../__snapshots__/api-test-pptr.js.snap       |  5 ++++
 4 files changed, 26 insertions(+), 17 deletions(-)

diff --git a/core/config/default-config.js b/core/config/default-config.js
index dcfd8671dcdf..3624038483d8 100644
--- a/core/config/default-config.js
+++ b/core/config/default-config.js
@@ -478,7 +478,6 @@ const defaultConfig = {
         {id: 'third-party-facades', weight: 0},
         {id: 'largest-contentful-paint-element', weight: 0},
         {id: 'lcp-lazy-loaded', weight: 0},
-        {id: 'layout-shift-elements', weight: 0},
         {id: 'layout-shifts', weight: 0},
         {id: 'uses-passive-event-listeners', weight: 0},
         {id: 'no-document-write', weight: 0},
@@ -505,6 +504,7 @@ const defaultConfig = {
         {id: 'final-screenshot', weight: 0, group: 'hidden'},
         {id: 'script-treemap-data', weight: 0, group: 'hidden'},
         {id: 'resource-summary', weight: 0, group: 'hidden'},
+        {id: 'layout-shift-elements', weight: 0, group: 'hidden'},
       ],
     },
     'accessibility': {
diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 67e0e7bbf467..5397b15a4ecb 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -4072,10 +4072,6 @@
                 "id": "lcp-lazy-loaded",
                 "weight": 0
               },
-              {
-                "id": "layout-shift-elements",
-                "weight": 0
-              },
               {
                 "id": "layout-shifts",
                 "weight": 0
@@ -4167,6 +4163,11 @@
                 "id": "resource-summary",
                 "weight": 0,
                 "group": "hidden"
+              },
+              {
+                "id": "layout-shift-elements",
+                "weight": 0,
+                "group": "hidden"
               }
             ],
             "id": "performance",
@@ -11129,10 +11130,6 @@
                 "id": "third-party-summary",
                 "weight": 0
               },
-              {
-                "id": "layout-shift-elements",
-                "weight": 0
-              },
               {
                 "id": "layout-shifts",
                 "weight": 0
@@ -11204,6 +11201,11 @@
                 "id": "resource-summary",
                 "weight": 0,
                 "group": "hidden"
+              },
+              {
+                "id": "layout-shift-elements",
+                "weight": 0,
+                "group": "hidden"
               }
             ],
             "id": "performance",
@@ -22189,10 +22191,6 @@
                 "id": "lcp-lazy-loaded",
                 "weight": 0
               },
-              {
-                "id": "layout-shift-elements",
-                "weight": 0
-              },
               {
                 "id": "layout-shifts",
                 "weight": 0
@@ -22284,6 +22282,11 @@
                 "id": "resource-summary",
                 "weight": 0,
                 "group": "hidden"
+              },
+              {
+                "id": "layout-shift-elements",
+                "weight": 0,
+                "group": "hidden"
               }
             ],
             "id": "performance",
diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json
index fae62ea19f2b..822981cdf6bb 100644
--- a/core/test/results/sample_v2.json
+++ b/core/test/results/sample_v2.json
@@ -6236,10 +6236,6 @@
           "id": "lcp-lazy-loaded",
           "weight": 0
         },
-        {
-          "id": "layout-shift-elements",
-          "weight": 0
-        },
         {
           "id": "layout-shifts",
           "weight": 0
@@ -6331,6 +6327,11 @@
           "id": "resource-summary",
           "weight": 0,
           "group": "hidden"
+        },
+        {
+          "id": "layout-shift-elements",
+          "weight": 0,
+          "group": "hidden"
         }
       ],
       "id": "performance",
diff --git a/core/test/scenarios/__snapshots__/api-test-pptr.js.snap b/core/test/scenarios/__snapshots__/api-test-pptr.js.snap
index 6fc0b9dd6d9f..0f21b2b7fdec 100644
--- a/core/test/scenarios/__snapshots__/api-test-pptr.js.snap
+++ b/core/test/scenarios/__snapshots__/api-test-pptr.js.snap
@@ -258,6 +258,7 @@ Array [
   "largest-contentful-paint",
   "largest-contentful-paint-element",
   "layout-shift-elements",
+  "layout-shifts",
   "lcp-lazy-loaded",
   "legacy-javascript",
   "link-in-text-block",
@@ -454,6 +455,7 @@ Array [
   "interaction-to-next-paint",
   "is-on-https",
   "layout-shift-elements",
+  "layout-shifts",
   "legacy-javascript",
   "long-tasks",
   "main-thread-tasks",
@@ -492,6 +494,7 @@ Array [
 
 exports[`Individual modes API startTimespan should compute ConsoleMessage results across a span of time 2`] = `
 Array [
+  "layout-shifts",
   "non-composited-animations",
   "preload-fonts",
   "third-party-summary",
@@ -515,6 +518,7 @@ Array [
   "interaction-to-next-paint",
   "is-on-https",
   "layout-shift-elements",
+  "layout-shifts",
   "legacy-javascript",
   "long-tasks",
   "main-thread-tasks",
@@ -556,6 +560,7 @@ Array [
   "bootup-time",
   "duplicated-javascript",
   "efficient-animated-content",
+  "layout-shifts",
   "legacy-javascript",
   "modern-image-formats",
   "network-rtt",