Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Google Tag Manager <noscript> #9748

Closed
alanablett opened this issue Sep 27, 2019 · 4 comments
Closed

Issue with Google Tag Manager <noscript> #9748

alanablett opened this issue Sep 27, 2019 · 4 comments

Comments

@alanablett
Copy link

Provide the steps to reproduce

Run LH on https://wd40.ca/

What is the current behavior?

Lighthouse reports PWA Issues

  • Redirects HTTP traffic to HTTPS
  • Contains some content when JavaScript is not available

What is the expected behavior?

Lighthouse does not report those issues

Resolution

It seems that the behaviour is related to the existence of the google tag manager <noscript><iframe> element on the page. Upon removing that element we see that both of the errors reported below disappear.

Environment Information

  • Affected Channels: Extension
  • Lighthouse version: 5.2.0
@patrickhulce
Copy link
Collaborator

Thanks for filing @alanablett! I'm not able to able to reproduce this issue though, everything passes on my end :/

Anything else about the repro steps might be relevant? Relevant settings or geo required to reproduce perhaps?

image

@alanablett
Copy link
Author

Thanks for your swift response @patrickhulce

There should be no difference in terms of geo or set up.

I actually just ran the test via the CLI instead, using lighthouse https://wd40.ca/ and lighthouse https://wd40.ca/ --chrome-flags="--headless" Seems that the headless browser doesn't have the issue. Screenshots below show the results. Any ideas what might be going on? Thanks

STANDARD-wd40 ca_2019-09-27_16-42-31 report html
HEADLESS-wd40 ca_2019-09-27_16-54-38 report html

@patrickhulce
Copy link
Collaborator

patrickhulce commented Sep 27, 2019

Ah thanks for the screenshots!

Do you see the warning message about the interstitial and the question mark in place of the PWA score? Those are trying to indicate that something went wrong while loading the page, not that the site has done something wrong :) In your case with the iframe, it's a root cause of #9562 and fixed in 5.4.0 which was just released. If you update LH, it should go away 👍

Going to close for now, but if latest LH doesn't fix the issue, feel free to chime back in :)

@alanablett
Copy link
Author

I can confirm that updating to 5.4.0 fixed the "issue". Many thanks for your help @patrickhulce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants