Fix NaN% in CLI report #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
force-pushed
the
clireportnan
branch
from
fab56a7
to
ee34e9e
Compare
paulirish
force-pushed
the
clireportnan
branch
from
ee34e9e
to
1082ed3
Compare
wardpeet
reviewed
Oct 11, 2016
| } | ||
|
|
||
| return weight; | ||
| let totalWeight = expectedNames.reduce((last, e) => last + (expected[e].weight || 0), 0); |
There was a problem hiding this comment.
In my opinion (expected[e].weight || 0)is a bit hard to read. maybe add a comment that you default to 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #761
Details for reviewers:
0/0==>NaNin the computing ofoverall. It was awkward. I've allowed them to have a value of0.0/maxScoreto resolve to 0 and notNaN.