Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit errorMessage not i18n'd #6804

Closed
exterkamp opened this issue Dec 14, 2018 · 0 comments · Fixed by #6812
Closed

Audit errorMessage not i18n'd #6804

exterkamp opened this issue Dec 14, 2018 · 0 comments · Fixed by #6812
Assignees
Labels

Comments

@exterkamp
Copy link
Member

Per Audit errorMessage are not i18n'd.

Who thought they could catch all i18n errors in 1 PR #6457 😢

      // Errors become error audit result.
      const errorMessage = err.friendlyMessage ?
        `${err.friendlyMessage} (${err.message})` :
        `Audit error: ${err.message}`;
      auditResult = Audit.generateErrorAuditResult(audit, errorMessage);
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant