Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect aspect ratio warning on SVG images #3818

Closed
TheDutchCoder opened this issue Nov 13, 2017 · 2 comments
Closed

Incorrect aspect ratio warning on SVG images #3818

TheDutchCoder opened this issue Nov 13, 2017 · 2 comments

Comments

@TheDutchCoder
Copy link

TheDutchCoder commented Nov 13, 2017

It looks like that validator has issues with embedded SVG's.

The validator fires off a warning about incorrect ratios, but it doesn't actually tell which images are supposedly the culprit(s).

My test page has no img images, only embedded SVG's (through a use) and it fails on aspect ratios. Could this be due to rounding in the browser?

E.g. my SVG has a viewbox of 0 0 413 70 (aspect ratio 1:5.9), but the browser sizes it to 140x23.72 (aspect ratio 1:5.902).

@patrickhulce
Copy link
Collaborator

Thanks for reporting @TheDutchCoder! This has actually already been fixed by #3722 and should go out with the next release sometime this week.

@TheDutchCoder
Copy link
Author

Gotcha, thanks.

I searched in issues but not in PR's, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants