Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing evaluation heading: "Address bar matches brand colors" #1106

Closed
dandv opened this issue Dec 3, 2016 · 9 comments
Closed

Confusing evaluation heading: "Address bar matches brand colors" #1106

dandv opened this issue Dec 3, 2016 · 9 comments
Assignees

Comments

@dandv
Copy link
Contributor

dandv commented Dec 3, 2016

When generating a report on this URL, Lighthouse suggests that the address bar matches the brand colors:

image

In actuality, the site's manifest.json has:

"background_color": "#1C3A6A",
"theme_color": "#FFFFFF"

The HTML theme-color is matched by the manifest's background_color, but the manifest theme_color is different (#FFFFFF, and Android renders the notification area in grey color).

image

Related: #25.

@paulirish
Copy link
Member

Ah we only care that it's defined, but we don't need anything to "match". Yes. agree the wording isn't ideal.

Maybe...

Address bar theming is defined

Address bar theme color applied

@paulirish
Copy link
Member

@kaycebasques wdyt on the name here. we just want these colors defined somewhere. that's it. And honestly we have no idea what your REAL brand colors are. :)

@pardismusic
Copy link

hi

i uesd these

and this inside my style :

{"theme_color": "#228f21" ...}

but i will get Address bar does not match brand colors (The browser address bar can be themed to match your site.)

what i have to do for fixing this ?
this is my website address : pardis music . me

@patrickhulce
Copy link
Collaborator

@pardismusic have you read the documentation? Do you have the meta tag?

@pardismusic
Copy link

pardismusic commented Dec 3, 2018

@pardismusic have you read the documentation? Do you have the meta tag?

hi
yes i used these 👍
< meta name="theme-color" content="#228f21" >
< meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" >

but i add 2 space between
< and > for showing here

@patrickhulce
Copy link
Collaborator

@pardismusic
Copy link

You don't have a manifest @pardismusic.

image

https://developers.google.com/web/tools/lighthouse/audits/manifest-exists#recommendations

i really didnt undrestand how to make manifest

is there any video to showing that ? or any site example

@patrickhulce
Copy link
Collaborator

Yes the documentation links to a guide https://developers.google.com/web/fundamentals/web-app-manifest/

@brendankenny
Copy link
Member

fixed in #6494!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants