Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate final screenshot in report #10016

Closed
connorjclark opened this issue Nov 24, 2019 · 1 comment · Fixed by #13123
Closed

Incorporate final screenshot in report #10016

connorjclark opened this issue Nov 24, 2019 · 1 comment · Fixed by #13123
Labels
needs-design P2 report

Comments

@connorjclark
Copy link
Collaborator

If we made a final viewport screenshot more prominent in the report, errors like this would be more obvious.

Alternatively, we could pick up the full-page screenshot #9064 and display that prominently.
@patrickhulce
Copy link
Collaborator

Related #9379, showing the screenshot with a mobile/desktop frame would go a long way to addressing the clarity issue.

@connorjclark connorjclark mentioned this issue Sep 2, 2020
Closed
@paulirish paulirish mentioned this issue Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-design P2 report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

report: display final screenshot prominently GoogleChrome/lighthouse
4 participants
@paulirish @brendankenny @patrickhulce @connorjclark