Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When assembly-versioning-scheme is set to none, AssemblyInfoBulider should not emit AssemblyVersion attribute #964

Closed
cortex93 opened this issue Jul 20, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@cortex93
Copy link

cortex93 commented Jul 20, 2016

Would it be possible that GitVersionTask do not write AssemblyVersion when assembly-versioning-scheme is set to none.
Actually, it writes [assembly: AssemblyVersion("")] which is not valid. It is not possible to add it's own AssemblyVersion attribute either as it will conflict.

Having the AssemblyInfoBuilder build the assemblyfile with only one format string does not allow opt-in/opt-out of version attribute.

@asbjornu
Copy link
Member

Yes, this would be a nice feature to have. Please submit a PR.

@stale
Copy link

stale bot commented Sep 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 26, 2019
@stale stale bot closed this as completed Oct 26, 2019
@hazzik
Copy link

hazzik commented Oct 13, 2022

Issue is still not resolved. Please reopen.

@asbjornu asbjornu added bug and removed stale labels Oct 13, 2022
@asbjornu asbjornu reopened this Oct 13, 2022
@HHobeck HHobeck added this to the 6.x milestone Mar 2, 2023
@arturcic
Copy link
Member

arturcic commented Mar 2, 2023

Fixed. should be available when next beta or stable version is released

@arturcic arturcic closed this as completed Mar 2, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.1 Mar 2, 2023
@arturcic
Copy link
Member

arturcic commented Mar 2, 2023

🎉 This issue has been resolved in version 6.0.0-beta.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants