From 9ef79eba2a2f57c148812e32251c3acc0584c044 Mon Sep 17 00:00:00 2001 From: Ghassen Rjab Date: Sat, 19 Dec 2020 23:05:23 +0100 Subject: [PATCH 1/4] Remove return true when validating --- src/lib/validate.js | 1 - src/lib/validate.test.js | 17 +++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lib/validate.js b/src/lib/validate.js index edbb61a..7383b92 100644 --- a/src/lib/validate.js +++ b/src/lib/validate.js @@ -32,5 +32,4 @@ export default (array, categories) => { if (uniqueCategoryNames.size !== categories.length) { throw new TypeError("categories must have unique names"); } - return true; }; diff --git a/src/lib/validate.test.js b/src/lib/validate.test.js index 5900cb2..1e0421e 100644 --- a/src/lib/validate.test.js +++ b/src/lib/validate.test.js @@ -6,18 +6,19 @@ test("arguments are validated", () => { { name: "Spencer", type: "Dog" }, { name: "Taxi", type: "Bird" }, ]; - const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; - const validatedArgs = validate(array, categories); - expect(validatedArgs).toBe(true); -}); - -test("array is required", () => { const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; expect(() => { - validate(undefined, categories); - }).toThrow(new TypeError("array is required")); + validate(array, categories); + }).not.toThrow(); }); +// test("array is required", () => { +// const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; +// expect(() => { +// validate(undefined, categories); +// }).toThrow(new TypeError("array is required")); +// }); + test("array must be an array", () => { const array = "categorize"; const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; From 275cfcea4e0869171b3450c3ea61ea03a52ad4df Mon Sep 17 00:00:00 2001 From: Ghassen Rjab Date: Sat, 19 Dec 2020 23:10:35 +0100 Subject: [PATCH 2/4] Recover missing unit test --- src/lib/validate.test.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/validate.test.js b/src/lib/validate.test.js index 1e0421e..b691cd2 100644 --- a/src/lib/validate.test.js +++ b/src/lib/validate.test.js @@ -12,12 +12,12 @@ test("arguments are validated", () => { }).not.toThrow(); }); -// test("array is required", () => { -// const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; -// expect(() => { -// validate(undefined, categories); -// }).toThrow(new TypeError("array is required")); -// }); +test("array is required", () => { + const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; + expect(() => { + validate(undefined, categories); + }).toThrow(new TypeError("array is required")); +}); test("array must be an array", () => { const array = "categorize"; From 2f60f98da783bfa95b1a549776bd98f31aa2f2ee Mon Sep 17 00:00:00 2001 From: Ghassen Rjab Date: Sat, 19 Dec 2020 23:14:13 +0100 Subject: [PATCH 3/4] Fail test --- src/lib/validate.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/validate.test.js b/src/lib/validate.test.js index b691cd2..7344154 100644 --- a/src/lib/validate.test.js +++ b/src/lib/validate.test.js @@ -16,7 +16,7 @@ test("array is required", () => { const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; expect(() => { validate(undefined, categories); - }).toThrow(new TypeError("array is required")); + }).not.toThrow(new TypeError("array is required")); }); test("array must be an array", () => { From e550bfb9d3398c345ff46b0ed683ec416d3badf7 Mon Sep 17 00:00:00 2001 From: Ghassen Rjab Date: Sat, 19 Dec 2020 23:15:58 +0100 Subject: [PATCH 4/4] Fix error --- src/lib/validate.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/validate.test.js b/src/lib/validate.test.js index 7344154..b691cd2 100644 --- a/src/lib/validate.test.js +++ b/src/lib/validate.test.js @@ -16,7 +16,7 @@ test("array is required", () => { const categories = [{ name: "cats", filter: ({ type }) => type === "Cat" }]; expect(() => { validate(undefined, categories); - }).not.toThrow(new TypeError("array is required")); + }).toThrow(new TypeError("array is required")); }); test("array must be an array", () => {