Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of notification.mark_read event #955

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

MartinCupela
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Add additional check before setting unread count for all active channels to 0. Check that the notification.mark_read event has unread_channels: 0.

@github-actions
Copy link
Contributor

Size Change: +45 B (0%)

Total Size: 299 kB

Filename Size Change
dist/browser.es.js 65.4 kB +8 B (0%)
dist/browser.full-bundle.min.js 35.7 kB +6 B (0%)
dist/browser.js 66.1 kB +10 B (0%)
dist/index.es.js 65.5 kB +9 B (0%)
dist/index.js 66.2 kB +12 B (0%)

compressed-size-action

@MartinCupela MartinCupela force-pushed the fix-notification-mark-read-all branch from f904485 to ba41349 Compare April 15, 2022 13:28
@vishalnarkhede vishalnarkhede changed the title fix: mark all active channels read only if notification.mark_read event's value of unread_channels is 0 fix: handling of notification.mark_read event Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants