Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'to' prop from button component #1535

Open
dlrussel opened this issue Sep 14, 2023 · 0 comments
Open

Remove 'to' prop from button component #1535

dlrussel opened this issue Sep 14, 2023 · 0 comments

Comments

@dlrussel
Copy link
Contributor

We should remove the to prop from the button component that is used to create a button that returns a Link.
This creates a confusing implementation because we shouldn't be building link functionality into our button component.
Links should be used to move to another page or move to another place within the same page while Buttons are for triggering actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant