Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify maybe_flush_rewrites() method #880

Open
1 task done
carstingaxion opened this issue Sep 17, 2024 · 0 comments
Open
1 task done

Simplify maybe_flush_rewrites() method #880

carstingaxion opened this issue Sep 17, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@carstingaxion
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

The current implementation of automated checks to see if it might be necessary to flush the rewrite rules is ok and working, but could be improved.

Designs

Instead of setting an own do_flush_the_rules option to check against, GatherPress could rely on WordPress core functionality to re-create the rewrite rules on the fly, if they don’t exist.

This is happening early on each request and checks for the existence of the rewrite_rules option.

I suggest that GatherPress just delete the rewrite_rules core option, if the rules need to be flushed.
And let WordPress handle the rest.

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant