Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings should be printed in separate mode #87

Open
buchslava opened this issue May 6, 2016 · 2 comments
Open

Warnings should be printed in separate mode #87

buchslava opened this issue May 6, 2016 · 2 comments

Comments

@buchslava
Copy link
Collaborator

We should not to see warnings by default. Only errors. We should use extra parameter during start of program to show warnings. For example,

validate-ddf <folder> -w - with warnings
validate-ddf <folder> - without warnings

@buchslava buchslava added this to the ddf1 milestone May 6, 2016
@buchslava buchslava changed the title Warnings should be pronted in separate mode Warnings should be printed in separate mode May 6, 2016
@buchslava
Copy link
Collaborator Author

I think this idea will be very useful for next case:

[{
    "type": "Incorrect JSON field",
    "path": "/home/slava/q3/ddf--concepts.csv",
    "data": {
        "column": "drill_up",
        "line": 14,
        "value": "['geographic_regions', 'income_groups', 'landlocked', 'g77_and_oecd_countries', 'geographic_regions_in_4_colors', 'main_religion_2008']"
    },
    "suggestions": ["[\"geographic_regions\",\"income_groups\",\"landlocked\",\"g77_and_oecd_countries\",\"geographic_regions_in_4_colors\",\"main_religion_2008\"]"],
    "warning": true
}, {
    "type": "Incorrect JSON field",
    "path": "/home/slava/q3/ddf--entities--geo--country.csv",
    "data": {
        "column": "arb5",
        "line": 55,
        "value": "Congo [DRC]"
    },
    "warning": true
}]

I mean next: "value": "Congo [DRC]"

this value looks like wrong JSON (from robot side), but we know that it's not true

@buchslava
Copy link
Collaborator Author

duplicated with #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant