Migrate to ReScript. #231
Merged
Migrate to ReScript. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerziegler
commented
Dec 9, 2020
Comment on lines
-70
to
-79
| }, | ||
| "lint-staged": { | ||
| "*.{re,rei}": [ | ||
| "bsrefmt --in-place" | ||
| ] | ||
| }, | ||
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } |
There was a problem hiding this comment.
Unfortunately, refmt no longer has support for in-place modification 😭 This means we can't do any sort of pre-commit or pre-merge checks and instead just need to ask people to use the VSCode extension or run refmt themselves :oof:
There was a problem hiding this comment.
We can likely just restore support by writing a small script 👍
kitten
approved these changes
Dec 9, 2020
kitten
reviewed
Dec 9, 2020
| @bs.send external toString: (int, int) => string = "toString" | ||
| @scope("Math") @val external random: unit => float = "random" | ||
| @scope("Math") @val external floor: float => int = "floor" | ||
| @send external toString: (int, int) => string = "toString" |
There was a problem hiding this comment.
:rip: Can't say I'm sad to see it go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go! When merged, this PR will officially migrate us from Reason to ReScript. While it does make the library name out of date 😂 I feel this change is important for the future maintenance of this project. We'll consider a name change down the road, likely in a future major.
The migration here is automated. For the curious, you can check out my hacky Bash script to run this 😂 . There's nothing really meaningful to review here. We'll release this as a new minor version (3.1.0) alongside #230, assuming no regressions caught in CI.