Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up to cosmos-sdk v0.45.10 #775

Closed
4 tasks done
zemyblue opened this issue Nov 1, 2022 · 2 comments
Closed
4 tasks done

bump up to cosmos-sdk v0.45.10 #775

zemyblue opened this issue Nov 1, 2022 · 2 comments
Assignees
Labels
A: improvement Changes in existing functionality

Comments

@zemyblue
Copy link
Member

zemyblue commented Nov 1, 2022

Summary

bump up to cosmos-sdk v0.45.10
https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.10

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dudong2 dudong2 self-assigned this Nov 2, 2022
@dudong2 dudong2 added the A: improvement Changes in existing functionality label Nov 2, 2022
@dudong2
Copy link
Contributor

dudong2 commented Nov 7, 2022

cachekv

From #441, map was changed to sync.Map. Since these functions are no longer managed, it is difficult to bump up with the changes in the code of cosmos-sdk. I did a performance test to see if I could actually revert it.

// lbm-sdk style
type Store struct {
	mtx           sync.RWMutex
	cache         sync.Map
	deleted       sync.Map
	unsortedCache sync.Map
	sortedCache   *dbm.MemDB // always ascending sorted
	parent        types.KVStore
}

// cosmos-sdk style
type Store struct {
	mtx           sync.Mutex
	cache         map[string]*cValue
	deleted       map[string]struct{}
	unsortedCache map[string]struct{}
	sortedCache   *dbm.MemDB // always ascending sorted
	parent        types.KVStore
}
machine spec: 3.3GHz 6core Inter Core i5 / 16GB DDR4
Sync.Map: 1845 tps
map: 1872 tps

When I reverted to the code in cosmos-sdk, the tps came out a bit high. So I decided to revert it.

@dudong2
Copy link
Contributor

dudong2 commented Nov 8, 2022

iavl disable fast node

From cosmos/cosmos-sdk#13540, there is no additional issue about changing the default value of iavlDisablefastNode to true.
I could not found any issues in terms of functionality and performance, so I decided to apply that pr as is.

@dudong2 dudong2 closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants