Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register legacy amino codec for support the ledger device #735

Closed
4 tasks
zemyblue opened this issue Oct 18, 2022 · 0 comments · Fixed by #745 or #736
Closed
4 tasks

Register legacy amino codec for support the ledger device #735

zemyblue opened this issue Oct 18, 2022 · 0 comments · Fixed by #745 or #736
Assignees
Labels
A: bug Something isn't working

Comments

@zemyblue
Copy link
Member

Summary of Bug

Since the Ledger device utilizes the Amino JSON representation of the message and the CosmJS is used by the majority of web applications connecting to Cosmos chains, this issue will make the integration of the Ledger device and CosmJS impossible.

We need to register the legacy amino codec In the following codec files.

  • x/auth/types/codec.go
  • x/auth/vesting/types/codec.go
  • x/authz/codec.go
  • x/bank/types/codec.go
  • x/collection/codec.go
  • x/crisis/types/codec.go
  • x/distribution/types/codec.go
  • x/evidence/types/codec.go
  • x/feegrant/codec.go
  • x/foundation/codec.go
  • x/gov/types/codec.go
  • x/ibc/applications/transfer/types.codec.go
  • x/ibc/core/types/codec.go
  • x/mint/types/codec.go
  • x/params/types/proposal/codec.go
  • x/slashing/types/codec.go
  • x/staking/types/codec.go
  • x/stakingplus/codec.go
  • x/token/codec.go
  • x/upgrade/types/codec.go
  • x/wasm/types/codec.go

The related PRs of cosmos-sdk

Version

lbm-sdk v0.46.0-rc8

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue self-assigned this Oct 18, 2022
@zemyblue zemyblue added the A: bug Something isn't working label Oct 18, 2022
@zemyblue zemyblue changed the title register legacy amino codec for support the ledger device Register legacy amino codec for support the ledger device Oct 18, 2022
@zemyblue zemyblue linked a pull request Oct 21, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
1 participant