Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation of CheckTx() asynchronization changes #579

Closed
4 tasks done
torao opened this issue Jul 5, 2022 · 1 comment
Closed
4 tasks done

Evaluation of CheckTx() asynchronization changes #579

torao opened this issue Jul 5, 2022 · 1 comment

Comments

@torao
Copy link
Contributor

torao commented Jul 5, 2022

Summary

Reconsideration of the effect of asynchronizing CheckTx() and separating it into CheckTxAsync() and CheckTxSync().

  • Report on the differences between current lbm-sdk and cosmos-sdk.
    • Aim of the change to lbm-sdk style implementation.
    • The actual effect of the lbm-sdk style implementation.
    • Consideration of the impact of this change on future cosmos-sdk merge task (e.g., how many changes are needed).
  • Decision whether to keep the lbm-sdk implementation or revert to the cosmos-sdk implementation.
  • If revert to a cosmos-sdk implementation, plan and progress of completing that work.

This task is to sort out useful features in order to reduce the differences between lbm-sdk and cosmos-sdk.

Parent: #549


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@torao
Copy link
Contributor Author

torao commented Jul 7, 2022

The CheckTxAsync() and related features in BaseApp that are the subject of this issue were introduced to implement Ostracon's abci/types/Application interface. This cannot be a target to be reverted for performance reasons alone, and is therefore excluded from the fix this time.

@torao torao closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant