Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyledTextArea no longer extends Control #342

Closed
effad opened this issue Jul 18, 2016 · 4 comments
Closed

StyledTextArea no longer extends Control #342

effad opened this issue Jul 18, 2016 · 4 comments

Comments

@effad
Copy link

effad commented Jul 18, 2016

StyledTextArea used to derive from javafx.scene.control.Control. In 0.7-M1 it no longer does, thus making it uncombinable with ControlsFX Validation which requires a Control to be passed.

Since StyledTextArea has all the characteristics of a Control it should derive from javafx.scene.control.Control.

@JordanMartinez
Copy link
Contributor

It no longer extends Control because we encountered multiple issues by adhering to that architecture mainly because of the inability to access the view.

See Tomas' comment which summarizes the problem nicely and #205 which explains another issue relating to the view. At the same time, #152 is now doable when it wasn't before.

@JordanMartinez
Copy link
Contributor

Additionally, feature requests like #150 are now easier / possible to implement.

@TomasMikula
Copy link
Member

For reasons mentioned by Jordan, extending Control means more trouble than benefits for us. Do you know if there is a good reason why ControlsFX Validation wouldn't work on nodes other than Control?

@effad
Copy link
Author

effad commented Jul 19, 2016

Thanks for the hints. It is clear now that this is not a mere oversight but a planned and reasonable design decision.

As to ControlsFX Validation requiring Control: From a quick glance it looks as if it should also work on any Node and it should just be a matter of adapting a lot of code to do so.

Considering the fact that the current validation stuff from ControlsFX should be improved / replaced anyway (https://bitbucket.org/controlsfx/controlsfx/issues/372/more-flexibility-in-validationsupport) this seems to be the correct end to change.

@effad effad closed this as completed Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants