BGP : Fix for nexthop as IPv4 mapped IPv6 address #6821

KaushikNiral · 2020-07-29T15:52:23Z

Added a macro to validate the IPv4 Mapped IPv6 address.
Modifications done for bgp receive and while sending updates
for IPv4 Mapped IPv6 address as nexthop.
Modifications done for installing IPv4 Mapped IPv6 address as nexthop
in RIB.
Minor correction done in fpm while sending the routes for
nexthop as IPv4 Mapped IPv6 address.

Signed-off-by: Kaushik kaushik@niralnetworks.com

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/bc22ed812fdc0f54732a3d3374e3f621/raw/2a3e1b37d8095f2aa3bd3620e67d960f6011b0bc/cr_6821_1596037947.diff | git apply

diff --git a/bgpd/bgp_updgrp_packet.c b/bgpd/bgp_updgrp_packet.c
index 684b4b7cd..5df9e3f23 100644
--- a/bgpd/bgp_updgrp_packet.c
+++ b/bgpd/bgp_updgrp_packet.c
@@ -577,7 +577,7 @@ struct stream *bpacket_reformat_for_peer(struct bpacket *pkt,
 		if (IN6_IS_ADDR_UNSPECIFIED(mod_v6nhg)) {
 			if (peer->nexthop.v4.s_addr) {
 				ipv4_to_ipv4_mapped_ipv6(mod_v6nhg,
-						peer->nexthop.v4);
+							 peer->nexthop.v4);
 			}
 		}
 
diff --git a/lib/ipaddr.h b/lib/ipaddr.h
index e26523fdb..5cb9ea562 100644
--- a/lib/ipaddr.h
+++ b/lib/ipaddr.h
@@ -93,12 +93,12 @@ static inline char *ipaddr2str(const struct ipaddr *ip, char *buf, int size)
 	return buf;
 }
 
-#define IS_MAPPED_IPV6(A)					\
-	((A)->s6_addr32[0] == 0x00000000			\
-	? ((A)->s6_addr32[1] == 0x00000000			\
-		? (ntohl((A)->s6_addr32[2]) == 0xFFFF ? 1 : 0)	\
-		: 0)						\
-		: 0)
+#define IS_MAPPED_IPV6(A)                                                      \
+	((A)->s6_addr32[0] == 0x00000000                                       \
+		 ? ((A)->s6_addr32[1] == 0x00000000                            \
+			    ? (ntohl((A)->s6_addr32[2]) == 0xFFFF ? 1 : 0)     \
+			    : 0)                                               \
+		 : 0)
 
 /*
  * Convert IPv4 address to IPv4-mapped IPv6 address which is of the

If you are a new contributor to FRR, please see our contributing guidelines.

LabN-CI · 2020-07-29T16:21:27Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6821 `fb598ae`
Date	07/29/2020
Start	11:55:42
Finish	12:21:22
Run-Time	25:40
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-29-11:55:42.txt
Log	autoscript-2020-07-29-11:56:41.log.bz2
Memory	498 498 426

For details, please contact louberger

LabN-CI · 2020-07-29T16:51:38Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6821 `c3c1906`
Date	07/29/2020
Start	12:25:41
Finish	12:51:33
Run-Time	25:52
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-29-12:25:41.txt
Log	autoscript-2020-07-29-12:26:35.log.bz2
Memory	482 499 426

For details, please contact louberger

NetDEF-CI · 2020-07-29T18:03:16Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13374/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 16:42:08,946 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 16:44:56,552 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-13374/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
2020-07-29 16:33:10,310 ERROR: ******************************************************************************
2020-07-29 16:33:10,310 ERROR: Test Target Summary                                                  Pass Fail
2020-07-29 16:33:10,310 ERROR: ******************************************************************************
2020-07-29 16:33:10,310 ERROR: FILE: scripts/check_linux_vrf.py
2020-07-29 16:33:10,311 ERROR: FILE: scripts/adjacencies.py
2020-07-29 16:33:10,311 ERROR: 51   r1     PE->PE3 (loopback) ping +0.01 secs                       0    1
2020-07-29 16:33:10,311 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2020-07-29 16:33:10,312 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_adjacencies": 1 tests failed
2020-07-29 16:40:56,439 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-07-29 16:40:56,693 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-07-29 16:40:56,946 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-07-29 16:40:57,197 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-07-29 16:43:54,066 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 18.04
Static analyzer (clang)
Ubuntu 20.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 0 on Ubuntu 18.04 amd64
Ubuntu 18.04 deb pkg check
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 2
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 amd64
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
Debian 10 deb pkg check
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
IPv4 ldp protocol on Ubuntu 18.04

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13374/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 16:42:08,946 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 16:44:56,552 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-13374/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
2020-07-29 16:33:10,310 ERROR: ******************************************************************************
2020-07-29 16:33:10,310 ERROR: Test Target Summary                                                  Pass Fail
2020-07-29 16:33:10,310 ERROR: ******************************************************************************
2020-07-29 16:33:10,310 ERROR: FILE: scripts/check_linux_vrf.py
2020-07-29 16:33:10,311 ERROR: FILE: scripts/adjacencies.py
2020-07-29 16:33:10,311 ERROR: 51   r1     PE->PE3 (loopback) ping +0.01 secs                       0    1
2020-07-29 16:33:10,311 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2020-07-29 16:33:10,312 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_adjacencies": 1 tests failed
2020-07-29 16:40:56,439 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-07-29 16:40:56,693 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-07-29 16:40:56,946 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-07-29 16:40:57,197 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-07-29 16:43:54,066 ERROR: Traceback (most recent call last):
  File "/root/share/topotests/lib/common_config.py", line 2094, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/share/topotests/lib/common_config.py", line 281, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/share/topotests/lib/common_config.py", line 555, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

Report for bgp_nht.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #150: FILE: /tmp/f1-11707/bgp_nht.c:150:
Report for zebra_nhg.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #1840: FILE: /tmp/f1-11707/zebra_nhg.c:1840:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13374/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-gfb598aeb3-0 (missing) -> 7.5-dev-20200729-01-gfb598aeb3-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-gfb598aeb3-0 (missing) -> 7.5-dev-20200729-01-gfb598aeb3-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-gfb598aeb3-0 (missing) -> 7.5-dev-20200729-01-gfb598aeb3-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-gfb598aeb3-0 (missing) -> 7.5-dev-20200729-01-gfb598aeb3-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-gfb598aeb3-0 (missing) -> 7.5-dev-20200729-01-gfb598aeb3-0~deb10u1

NetDEF-CI · 2020-07-29T18:10:10Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13375/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13375/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 16:46:22,017 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 16:49:08,844 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13375/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 amd64
Static analyzer (clang)
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 0 on Ubuntu 18.04 amd64
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 amd64
Addresssanitizer topotests part 2
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
IPv4 ldp protocol on Ubuntu 18.04
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13375/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 16:46:22,017 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 16:49:08,844 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13375/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Report for bgp_nht.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #150: FILE: /tmp/f1-16170/bgp_nht.c:150:
Report for zebra_nhg.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #1840: FILE: /tmp/f1-16170/zebra_nhg.c:1840:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13375/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-02-gc3c190626-0 (missing) -> 7.5-dev-20200729-02-gc3c190626-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-02-gc3c190626-0 (missing) -> 7.5-dev-20200729-02-gc3c190626-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-02-gc3c190626-0 (missing) -> 7.5-dev-20200729-02-gc3c190626-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-02-gc3c190626-0 (missing) -> 7.5-dev-20200729-02-gc3c190626-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-02-gc3c190626-0 (missing) -> 7.5-dev-20200729-02-gc3c190626-0~deb10u1

sworleys · 2020-07-29T19:08:11Z

@KaushikNiral you need to fix your commit messages to include the code directory touched

the first should be lib,zebra,bgpd: and the second lib,bgpd:

like stated here: http://docs.frrouting.org/projects/dev-guide/en/latest/workflow.html#commit-messages

KaushikNiral · 2020-07-29T20:51:25Z

@KaushikNiral you need to fix your commit messages to include the code directory touched

the first should be lib,zebra,bgpd: and the second lib,bgpd:

like stated here: http://docs.frrouting.org/projects/dev-guide/en/latest/workflow.html#commit-messages

@sworleys , fixed the commit message.

Thanks,

LabN-CI · 2020-07-29T21:16:44Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6821 `3bdf24f`
Date	07/29/2020
Start	16:50:41
Finish	17:16:39
Run-Time	25:58
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-29-16:50:41.txt
Log	autoscript-2020-07-29-16:51:39.log.bz2
Memory	499 497 428

For details, please contact louberger

NetDEF-CI · 2020-07-29T23:04:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13382/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 21:35:04,914 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 21:37:51,937 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-13382/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-07-29 21:30:26,739 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 21:31:59,290 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 16.04 deb pkg check
Topo tests part 1 on Ubuntu 16.04 i386
Fedora 29 rpm pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 0
Debian 8 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
IPv4 ldp protocol on Ubuntu 18.04
Topo tests part 1 on Ubuntu 18.04 amd64
Static analyzer (clang)
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topo tests part 2 on Ubuntu 16.04 amd64
Addresssanitizer topotests part 2
Topo tests part 1 on Ubuntu 16.04 amd64

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-13382/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:

*** Error setting resource limits. Mininet's performance may be affected.
*** defaultIntf: warning: r1 has no interfaces
2020-07-29 21:35:04,914 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 21:37:51,937 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-13382/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-07-29 21:30:26,739 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_chaos_topo1/test_verify_overlay_index_p1": Testcase test_verify_overlay_index_p1 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True
2020-07-29 21:31:59,290 ERROR: assert failed at "evpn_type5_test_topo1.test_evpn_type5_topo1/test_RD_verification_manual_and_auto_p0": Testcase test_RD_verification_manual_and_auto_p0 :Failed 
   Error: No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli
assert "No output for 'show bgp l2vpn evpn 10.1.1.1 json' cli" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for bgp_nht.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #150: FILE: /tmp/f1-12041/bgp_nht.c:150:
Report for zebra_nhg.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #1840: FILE: /tmp/f1-12041/zebra_nhg.c:1840:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13382/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-g3bdf24f1a-0 (missing) -> 7.5-dev-20200729-01-g3bdf24f1a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-g3bdf24f1a-0 (missing) -> 7.5-dev-20200729-01-g3bdf24f1a-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-g3bdf24f1a-0 (missing) -> 7.5-dev-20200729-01-g3bdf24f1a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-g3bdf24f1a-0 (missing) -> 7.5-dev-20200729-01-g3bdf24f1a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200729-01-g3bdf24f1a-0 (missing) -> 7.5-dev-20200729-01-g3bdf24f1a-0~deb10u1

sworleys · 2020-08-03T17:32:16Z

@KaushikNiral can you rebase? Hopefully the topotests have been fixed... I dont think they are related to this PR.

Added a macro to validate the v4 mapped v6 address. Modified bgp receive & send updates for v4 mapped v6 address as nexthop and installing it as recursive nexthop in RIB. Minor change in fpm while sending the routes for nexthop as v4 mapped v6 address. Signed-off-by: Kaushik <kaushik@niralnetworks.com>

KaushikNiral · 2020-08-04T07:08:06Z

@KaushikNiral can you rebase? Hopefully the topotests have been fixed... I dont think they are related to this PR.

@sworleys this is done.

LabN-CI · 2020-08-04T07:46:39Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6821 `92d6f76`
Date	08/04/2020
Start	03:20:41
Finish	03:46:34
Run-Time	25:53
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-08-04-03:20:41.txt
Log	autoscript-2020-08-04-03:21:39.log.bz2
Memory	493 489 420

For details, please contact louberger

NetDEF-CI · 2020-08-04T09:09:18Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13458/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_nht.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #150: FILE: /tmp/f1-30810/bgp_nht.c:150:
Report for zebra_nhg.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #1840: FILE: /tmp/f1-30810/zebra_nhg.c:1840:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13458/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200804-01-g92d6f7698-0 (missing) -> 7.5-dev-20200804-01-g92d6f7698-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200804-01-g92d6f7698-0 (missing) -> 7.5-dev-20200804-01-g92d6f7698-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200804-01-g92d6f7698-0 (missing) -> 7.5-dev-20200804-01-g92d6f7698-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200804-01-g92d6f7698-0 (missing) -> 7.5-dev-20200804-01-g92d6f7698-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200804-01-g92d6f7698-0 (missing) -> 7.5-dev-20200804-01-g92d6f7698-0~deb10u1

polychaeta reviewed Jul 29, 2020

View reviewed changes

KaushikNiral mentioned this pull request Jul 29, 2020

Fix for nexthop as IPv4 mapped IPv6 address #6454

Closed

sworleys self-requested a review July 29, 2020 19:02

KaushikNiral force-pushed the niral_6VPE_6PE_fix branch from c3c1906 to 3bdf24f Compare July 29, 2020 20:47

polychaeta added bgp libfrr zebra labels Jul 29, 2020

KaushikNiral force-pushed the niral_6VPE_6PE_fix branch from 3bdf24f to 92d6f76 Compare August 4, 2020 07:06

sworleys approved these changes Aug 4, 2020

View reviewed changes

sworleys merged commit c117742 into FRRouting:master Aug 4, 2020

This was referenced Oct 22, 2020

BGP for 6PE with FRR version 7.3 #6341

Closed

BGP for 6VPE with FRR version 7.3 #6382

Closed

AkhileshSamineni mentioned this pull request Nov 18, 2020

FRR patches to support IPv6 Link local enhancements. sonic-net/sonic-buildimage#5584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BGP : Fix for nexthop as IPv4 mapped IPv6 address #6821

BGP : Fix for nexthop as IPv4 mapped IPv6 address #6821

KaushikNiral commented Jul 29, 2020

polychaeta left a comment

LabN-CI commented Jul 29, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jul 29, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 29, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

NetDEF-CI commented Jul 29, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

sworleys commented Jul 29, 2020

KaushikNiral commented Jul 29, 2020

LabN-CI commented Jul 29, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 29, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

sworleys commented Aug 3, 2020

KaushikNiral commented Aug 4, 2020

LabN-CI commented Aug 4, 2020

NetDEF-CI commented Aug 4, 2020

BGP : Fix for nexthop as IPv4 mapped IPv6 address #6821

BGP : Fix for nexthop as IPv4 mapped IPv6 address #6821

Conversation

KaushikNiral commented Jul 29, 2020

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Jul 29, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jul 29, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 29, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

NetDEF-CI commented Jul 29, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

sworleys commented Jul 29, 2020

KaushikNiral commented Jul 29, 2020

LabN-CI commented Jul 29, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 29, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

sworleys commented Aug 3, 2020

KaushikNiral commented Aug 4, 2020

LabN-CI commented Aug 4, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 4, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

LabN-CI commented Jul 29, 2020 •

edited

Loading

LabN-CI commented Jul 29, 2020 •

edited

Loading

NetDEF-CI commented Jul 29, 2020 •

edited

Loading

NetDEF-CI commented Jul 29, 2020 •

edited

Loading

LabN-CI commented Jul 29, 2020 •

edited

Loading

NetDEF-CI commented Jul 29, 2020 •

edited

Loading