Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXIV2_ENABLE_XMP=Off incorrectly uses #include <expat.h> #1971

Closed
trufanov-nok opened this issue Oct 19, 2021 · 3 comments · Fixed by #1973 or #1972
Closed

EXIV2_ENABLE_XMP=Off incorrectly uses #include <expat.h> #1971

trufanov-nok opened this issue Oct 19, 2021 · 3 comments · Fixed by #1973 or #1972
Assignees
@kevinbackhouse
Milestone
v0.27.5

Comments

@trufanov-nok
Copy link

Hi,
I'm considering to use Exiv2 to copy/paste ICC profiles only. Thus it looks like I don't need XMP support and additional lib Expat dependency. So I tried to generate Exiv2 solution for Visual Studio using: cmake -G "Visual Studio 12" -D EXIV2_ENABLE_XMP=Off ... Then I tried to build it and got:

Error	4	error C1083: Cannot open include file: 'expat.h': No such file or directory	C:\tmp\exiv2-0.27\src\xmp.cpp	33	1	exiv2lib

It look like it builds if I comment this include.
Shouldn't this include be under some #ifdef?
@kevinbackhouse kevinbackhouse mentioned this issue Oct 19, 2021
Merged
@kevinbackhouse
Copy link
Collaborator

Thanks. I did this by accident in #1878. I have created #1972 to fix it.

@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Oct 19, 2021
@kevinbackhouse kevinbackhouse self-assigned this Oct 19, 2021
@kevinbackhouse
Copy link
Collaborator

@trufanov-nok: please can you check that it works with #1972? I have expat installed, so the build is always going to succeed on my computer.

@clanmills clanmills changed the title EXIV2_ENABLE_XMP=Off leaves a refference to Expat EXIV2_ENABLE_XMP=Off incorrectly uses #include <expat.h> Oct 19, 2021
This was linked to pull requests Oct 19, 2021
Only include expat.h when XMP is enabled. (backport #1972) #1973
Merged
Only include expat.h when XMP is enabled. #1972
Merged
@trufanov-nok
Copy link
Author

Look like it's working.

@clanmills clanmills mentioned this issue Oct 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinbackhouse kevinbackhouse

Labels
None yet
Projects
None yet
Milestone
v0.27.5
2 participants
@kevinbackhouse @trufanov-nok