Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cmake/compilerFlags.cmake to avoid problem with exotic environments #1355

Open
piponazo opened this issue Oct 13, 2020 · 2 comments
Assignees
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Milestone

Comments

@piponazo
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In cmake/compilerFlags.cmake we have a section were we try to find out if some of the following compiler flags are available and we try to use them: -fstack-clash-protection -fcf-protection -fstack-protector-strong -Wp,-D_GLIBCXX_ASSERTIONS -Wp,-D_FORTIFY_SOURCE=2.

When this was introduced it looked like a good idea, and it has helped us to find/debug some bugs. However, it is also true that we had to deal with those flags to enable the support of non common Linux Distributions or other more existing development environments (CYGWIN, MSYS2-MinGW, etc).

Describe the solution you'd like
I think it would be beneficial to remove the complex logic in cmake/compilerFlags.cmake around those compiler flags, to have better support for exotic environments and linux distributions. Linux distribution packagers can still pass those compiler flags when building the Exiv2 library, by means of the CMAKE_CXX_FLAGS variable when calling cmake for the first time.

@piponazo piponazo added the request feature request or any other kind of wish label Oct 13, 2020
@piponazo piponazo self-assigned this Oct 13, 2020
@clanmills clanmills added this to the v1.00 milestone Apr 12, 2021
@clanmills
Copy link
Collaborator

I think that is more-or-less the same as #1235 and #1406.

@piponazo
Copy link
Collaborator Author

I think I created this issue when I was working in the old-master branch and I was having troubles with some of the less usual environments (trying to add support for ARM or MinGW; I cannot recall with precision at the moment).

I'll double check these things when I start working on main.

@clanmills clanmills added refactoring Cleanup / Simplify code -> more readable / robust and removed request feature request or any other kind of wish labels Apr 13, 2021
@kevinbackhouse kevinbackhouse modified the milestones: v0.28.0, Backlog Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

No branches or pull requests

3 participants