-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification about "working with any ref" changes #351
Comments
Hi, thanks for using the action! By default I would set it up like this: - uses: actions/checkout@v2
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }} You can find the full docs for payloads of If you're planning on running this only on "internal" PRs then you could omit the PS: I see that your workflow runs on both Anyway, I think this is something worthy of putting in the FAQ section of the README, since other people might want to use the action in this scenario. I hope this solves your issue! |
I have the same problem, the action fails (https://github.com/fasanosalvatore/FitDiary/runs/4908561536?check_suite_focus=true) on pull_request event even if I set the ref parameter as indicated. |
@fasanosalvatore |
that was what I was missing, Thanks for the pointer. I already handled forks and dependabot by checking the permissions since that covers my use case better 😄 Just adding My PR is passing now. 🎉 ℹ️ I actually still have part of my CI running |
Happy to hear that! |
@all-contributors please add @prince-chrismc for their docs contribution |
I've put up a pull request to add @prince-chrismc! 🎉 |
This fix has been published in |
👋 First off, thank you for this action (it's a huge help)
I was updating my repo to the latest version v8 because I wanted to take advantage of
In my workflow on a
pull_request
event I simply use the default option withactions/checkout@v2
hereHowever this fails https://github.com/prince-chrismc/label-merge-conflicts-action/runs/4892752781?check_suite_focus=true#step:8:79 with
fatal: You are not currently on a branch.
My use case is very similar to the example https://github.com/EndBug/add-and-commit#automated-linting just a different event 🤔
Do you have any suggestion or ideas to help me debug this issue?
Thanks in advance ❤️
The text was updated successfully, but these errors were encountered: