Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update from source repository #32

Merged
merged 187 commits into from
Oct 23, 2017
Merged

chore: update from source repository #32

merged 187 commits into from
Oct 23, 2017

Conversation

kennethlynne
Copy link

@kennethlynne kennethlynne commented Oct 11, 2017

Get updates from FaridSafi/react-native-gifted-chat to be closer to their implementation to allow us to more easily get in future fixes and features, and stuff like flat list implementation from a fork

This change is Reviewable

brianinator and others added 30 commits August 15, 2016 17:35
…#185

Add prop optionTintColor for ActionSheet options text
Now are UUIDs generated with `node-uuid` and is possible to change this
behavior using `messageIdGenerator` prop.
Refactor utils into stand-alone functions
Add prop for tintColor for ActionSheet in Actions FaridSafi#185
Removed a few unnecessarily strict rules, so we're
down to 486 errors now.
Add eslint script (extends airbnb + react + react-native)
Currently the fix is unpublished.
@sondremare
Copy link

Reviewed 45 of 45 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


package.json, line 32 at r1 (raw file):

  "scripts": {
    "lint": "eslint . --ext .js,.jsx",
    "test": "npm run lint"

why is this removed?


Comments from Reviewable

@sondremare
Copy link

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


package.json, line 48 at r1 (raw file):

    "prop-types": "15.5.10",
    "react-native-communications": "2.2.1",
    "react-native-invertible-scroll-view": "1.0.0",

this will most likely break Android 7 versions due to transform scale: -1 problem


Comments from Reviewable

@sondremare
Copy link

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


src/GiftedChat.js, line 263 at r1 (raw file):

    this.setKeyboardHeight(e.endCoordinates ? e.endCoordinates.height : e.end.height);
    this.setBottomOffset(this.props.bottomOffset);
    const newMessagesContainerHeight = this.getMessagesContainerHeightWithKeyboard();

All of these changes to height needs to be tested thoroughly.

  • When we hide input.
  • When keyboard is active
  • etc.. (couldnt think of anyone else atm)

Comments from Reviewable

@denistakeda
Copy link

:lgtm:


Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


Comments from Reviewable

@kennethlynne
Copy link
Author

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


package.json, line 32 at r1 (raw file):

Previously, sondremare wrote…

why is this removed?

not in line with what is on their master, and it breaks the build


Comments from Reviewable

@kennethlynne
Copy link
Author

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


package.json, line 48 at r1 (raw file):

Previously, sondremare wrote…

this will most likely break Android 7 versions due to transform scale: -1 problem

Comments in our fork said it was fixed in RN 0.48 >


Comments from Reviewable

@kennethlynne
Copy link
Author

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


src/GiftedChat.js, line 263 at r1 (raw file):

Previously, sondremare wrote…

All of these changes to height needs to be tested thoroughly.

  • When we hide input.
  • When keyboard is active
  • etc.. (couldnt think of anyone else atm)

Will do


Comments from Reviewable

@denistakeda
Copy link

:lgtm:


Review status: 42 of 45 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


Comments from Reviewable

@kennethlynne
Copy link
Author

Reviewed 42 of 45 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


src/GiftedChat.js, line 568 at r2 (raw file):

  renderSend: PropTypes.func,
  renderTime: PropTypes.func,
  renderSuggestions: PropTypes.func,

I do not see renderSuggestions on the right hand side now, missing? Does suggestions still work?


Comments from Reviewable

@kennethlynne
Copy link
Author

:lgtm:


Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


Comments from Reviewable

@sondremare
Copy link

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


src/GiftedChat.js, line 568 at r2 (raw file):

Previously, kennethlynne (Kenneth Lynne) wrote…

I do not see renderSuggestions on the right hand side now, missing? Does suggestions still work?

Suggetstions still work, but will readd this proptype


Comments from Reviewable

@sondremare sondremare merged commit 4186900 into master Oct 23, 2017
@sondremare sondremare deleted the upgrade branch October 23, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.