Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to disable marker tooltip #143

Closed
b4rtt opened this issue Jul 15, 2017 · 13 comments
Closed

Possibility to disable marker tooltip #143

b4rtt opened this issue Jul 15, 2017 · 13 comments

Comments

@b4rtt
Copy link

b4rtt commented Jul 15, 2017

Hi, is it possible? If yes, how?

Thank you

@EddyVerbruggen
Copy link
Collaborator

Have you tried not setting the title attribute?

@b4rtt
Copy link
Author

b4rtt commented Jul 16, 2017

@EddyVerbruggen When I delete tittle and subtitle then marker icon doesn't working :D

@EddyVerbruggen
Copy link
Collaborator

Ah ok. Perhaps you can do some research on the Mapbox website and github repo and report your findings?

@b4rtt
Copy link
Author

b4rtt commented Jul 16, 2017

@EddyVerbruggen

I found this: mapbox/mapbox-gl-native#3559

In Mapbox it should be solved. When is title empty then tooltip should be hidden on click.

@EddyVerbruggen
Copy link
Collaborator

Ah, that's perfect, so they fixed that a while ago. I will look into it.

@EddyVerbruggen
Copy link
Collaborator

EddyVerbruggen commented Jul 20, 2017

Hey @b4rtt I just tried with the current version and it works if you do it like this.

@b4rtt
Copy link
Author

b4rtt commented Jul 21, 2017

@EddyVerbruggen How should I update it? I have 3.0.1 version and when I delete Title and subtitle (same as in you code), icon is default and tap doesn't working https://github.com/b4rtt/PiratiGo

@EddyVerbruggen
Copy link
Collaborator

@b4rtt iOS or Android?
I cloned your repo but I only see a Google login button, no map (iOS).

@b4rtt
Copy link
Author

b4rtt commented Jul 25, 2017

@EddyVerbruggen I developing it only for iOS now.

Yes, sorry I made progress in my app. If you don't mind it you can login. (it's only login - after login you can see map)

BTW It's for other topic, but when I try to build it for Android building crashes. (because Firebase - don't know why)

I know that you are GOD creator of Firebase too. You can look for it too? Maybe will be better to create issue in Firebase repo?

@EddyVerbruggen
Copy link
Collaborator

The problem is I can't login (see screenshot). And the console is flooded with errors. Can you please run the Mapbox demo and see if that code I linked to previously works?

simulator screen shot 25 jul 2017 10 43 19

@EddyVerbruggen EddyVerbruggen added this to the 3.0.2 milestone Aug 5, 2017
@EddyVerbruggen
Copy link
Collaborator

I don't think this was published to npm - it's part of 3.0.2.

@ExaltedJim
Copy link

@EddyVerbruggen Is it possible to have markers on the map without a tooltip but still have the onTap for a marker fire? I have tried not setting the title and no tooltip is displayed, but my onTap function doesn't fire. If I add the title attribute back, the onTap does fire, but I get the tooltip that I don't want to display.

Any advice would be appreciated.

Cheers

@EddyVerbruggen EddyVerbruggen modified the milestones: 3.0.3, 3.0.2 Aug 8, 2017
@EddyVerbruggen
Copy link
Collaborator

Good call, @ExaltedJim - with 3.0.3 you can do just that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants