Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single mustache template to generate docker-compose.yml #1193

Open
kirtangajjar opened this issue Aug 28, 2018 · 1 comment
Open

Use single mustache template to generate docker-compose.yml #1193

kirtangajjar opened this issue Aug 28, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@kirtangajjar
Copy link
Contributor

Currently both site-command and site-wp-command has a seperate docker-compose.yml.
This makes making changes and keeping them consistent harder.

We need to keep only single docker-compose.yml in any one repo (preferably easyengine as we already need it for global docker-compose.yml). Whenever we need to generate docker-compose.yml, we'll use that template.

@kirtangajjar kirtangajjar added the good first issue Good for newcomers label Aug 28, 2018
@mrrobot47
Copy link
Member

mrrobot47 commented Aug 28, 2018

Comments from this PR discussion are relevant for this. Similar idea, to reduce the repeatability has been discussed here. To add the mustache template in the core as well as creating docker-compose utility to further reduce the steps in the site-commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants