Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti Xeno Military pilots in Titan Debris Fields #2604

Closed
Darkcyde13 opened this issue Mar 31, 2024 · 2 comments
Closed

Anti Xeno Military pilots in Titan Debris Fields #2604

Darkcyde13 opened this issue Mar 31, 2024 · 2 comments
Assignees
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users.

Comments

@Darkcyde13
Copy link

Darkcyde13 commented Mar 31, 2024

There are new Anti Xeno Military pilots in the Titan debris fields (only Taranis at the moment), and EDDI does not seem to handle them correctly in the 'Ship targeted' event.

The Ship targeted script voices the $Name_AX_Military; as part of the name, so I think this just needs to be replaced before EDDI uses it.

Journal entries for Ship targeted:

{ "timestamp":"2024-03-31T00:53:55Z", "event":"ShipTargeted", "TargetLocked":true, "Ship":"anaconda", "ScanStage":1, "PilotName":"$Name_AX_Military; Gregory", "PilotRank":"Master" }
{ "timestamp":"2024-03-31T00:53:58Z", "event":"ShipTargeted", "TargetLocked":true, "Ship":"anaconda", "ScanStage":2, "PilotName":"$Name_AX_Military; Gregory", "PilotRank":"Master", "ShieldHealth":100.000000, "HullHealth":100.000000 }
{ "timestamp":"2024-03-31T00:54:00Z", "event":"ShipTargeted", "TargetLocked":true, "Ship":"anaconda", "ScanStage":3, "PilotName":"$Name_AX_Military; Gregory", "PilotRank":"Master", "ShieldHealth":100.000000, "HullHealth":100.000000, "Faction":"Earls of Barati", "LegalStatus":"Lawless" }
{ "timestamp":"2024-03-31T00:54:01Z", "event":"ShipTargeted", "TargetLocked":true, "Ship":"anaconda", "ScanStage":3, "PilotName":"$Name_AX_Military; Gregory", "PilotRank":"Master", "ShieldHealth":100.000000, "HullHealth":100.000000, "Faction":"Earls of Barati", "LegalStatus":"Lawless", "Subsystem":"$modularcargobaydoor_name;", "Subsystem_Localised":"Cargo Hatch", "SubsystemHealth":100.000000 }

I'd guess that these are similar to the existing AX Pilots, just with a pilot name appended to the end?

EDIT: I thought it was happening in the Message received event too, but I had missed the output in speechresponder.out file, so I've removed my references to that.

@Darkcyde13 Darkcyde13 changed the title New Anti Xeno Military pilots in Titan Debris Fields Anti Xeno Military pilots in Titan Debris Fields Mar 31, 2024
@Tkael Tkael self-assigned this Mar 31, 2024
@Tkael Tkael added the 8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. label Mar 31, 2024
@Tkael
Copy link
Member

Tkael commented Mar 31, 2024

Normally there's a PilotName_Localised field that would contain a friendlier name (and EDDI would prefer that name if it were present). We've seen some cases where Frontier have skipped using this field. This looks like one of those cases. Thanks!

@Tkael
Copy link
Member

Tkael commented Mar 31, 2024

Fixed for the next release. 5181904

@Tkael Tkael closed this as completed Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users.
Projects
None yet
Development

No branches or pull requests

2 participants