Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2502 #2503

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: #2502 #2503

merged 1 commit into from
Sep 23, 2024

Conversation

koderx
Copy link

@koderx koderx commented Sep 20, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2502

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 643541e:

Sandbox Source
pr-story Configuration

@pointhalo
Copy link
Collaborator

@DaiQiangReal Review一下看看,初看了下这个修改应该是合理的。
不过对原有的逻辑我有点疑惑,notifyChange不应该是受控、非受控都应该被触发吗,除了这个修改外,我们原来的写法似乎还是就是有问题的?
非受控情况下,onChange没有被触发是不符合预期的吧?

@DaiQiangReal DaiQiangReal merged commit a7a7c67 into DouyinFE:main Sep 23, 2024
7 of 8 checks passed
Copy link

cypress bot commented Sep 23, 2024

semi-design    Run #2841

Run Properties:  status check failed Failed #2841  •  git commit a7a7c6707f: Merge pull request #2503 from koderx/fix-2502
Project semi-design
Branch Review main
Run status status check failed Failed #2841
Run duration 07m 49s
Commit git commit a7a7c6707f: Merge pull request #2503 from koderx/fix-2502
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 263
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PinCode初值为''时onChange不触发
3 participants