Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tabs and overflowList some api #2288

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

DaiQiangReal
Copy link
Collaborator

@DaiQiangReal DaiQiangReal commented Jun 7, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

image

image

Changelog

🇨🇳 Chinese

  • Feat: Tabs 添加 visibleTabsStyle 用于设置滚动区域样式
  • Feat: Tabs 添加 renderArrow 用于自定义滚动折叠模式下,左右切换器的渲染
  • Feat: Tabs 添加 arrowPosition 设置滚动折叠模式下,箭头切换器的渲染位置
  • Feat: Tabs 添加 overflowVisibleStateChange 用于在 tabs 溢出时获取未隐藏的项目
  • Feat: OverflowList 在 scroll 模式下添加 onVisibleStateChange 用于在溢出时获取未隐藏的项目

🇺🇸 English

  • Feat: Tabs add visibleTabsStyle to set the scroll area style
  • Feat: Tabs add renderArrow to customize the rendering of the left and right switches in scroll collapse mode
  • Feat: Tabs add arrowPosition to set the rendering position of the arrow switch in scroll collapse mode
  • Feat: Tabs add overflowVisibleStateChange to get unhidden items when tabs overflow
  • Feat: OverflowList add onVisibleStateChange in scroll mode to get unhidden items when overflowing

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Jun 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1e345d:

Sandbox Source
pr-story Configuration

@DaiQiangReal
Copy link
Collaborator Author

DaiQiangReal commented Jun 11, 2024

  1. 用于支持外部传入样式实现下方视频效果,即边缘渐变效果
20240611-170202.mp4
  1. 用于支持修改 tabs 溢出按钮位置
    img_v3_02bo_eb034142-bcc3-44ee-9fb6-3a0226b2862g

Copy link

codesandbox-ci bot commented Jun 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c2d3fb0:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Jun 12, 2024

Passing run #2562 ↗︎

0 260 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 80e3975 into 0d1719d...
Project: semi-design Commit: be08bfbf5f ℹ️
Status: Passed Duration: 10:43 💡
Started: Jun 12, 2024 12:24 PM Ended: Jun 12, 2024 12:35 PM

Review all test suite changes for PR #2288 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (c248a98) to head (be08bfb).
Report is 23 commits behind head on release.

Current head be08bfb differs from pull request most recent head 80e3975

Please upload reports for the commit 80e3975 to get more accurate results.

Files Patch % Lines
packages/semi-ui/avatar/index.tsx 58.33% 5 Missing ⚠️
packages/semi-ui/overflowList/index.tsx 61.53% 5 Missing ⚠️
packages/semi-ui/tabs/TabBar.tsx 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2288      +/-   ##
===========================================
- Coverage    88.26%   88.23%   -0.03%     
===========================================
  Files          441      441              
  Lines        26072    26096      +24     
  Branches      6659     6664       +5     
===========================================
+ Hits         23012    23026      +14     
- Misses        3060     3070      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit 21c7597 into release Jun 18, 2024
1 check passed
@pointhalo pointhalo deleted the feat_tabs_overflowList branch June 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants