Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt file-local types from SA1402 [resolves #3803] #3879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

6bee
Copy link

@6bee 6bee commented Jul 31, 2024

Fixes #3803 by adding support for file-local types feature

@6bee 6bee changed the title Exempt file-local types from SA1402 [resolves #3803] Exemp file-local types from SA1402 [resolves #3803] Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 98.52941% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.44%. Comparing base (ff5c432) to head (9bff5a2).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   97.45%   97.44%   -0.01%     
==========================================
  Files         926      939      +13     
  Lines      110237   110458     +221     
  Branches     3315     3321       +6     
==========================================
+ Hits       107433   107640     +207     
- Misses       1837     1847      +10     
- Partials      967      971       +4     

@6bee
Copy link
Author

6bee commented Aug 3, 2024

I'm note sure why "Test C# 12 Release Test C# 12" is failing. It doesn't look like this can be fixed in the code.
Can someone please re-trigger the build step?

@bjornhellander
Copy link
Contributor

The quickest way is for yourself to amend the latest commit and force-push.

@6bee 6bee changed the title Exemp file-local types from SA1402 [resolves #3803] Exempt file-local types from SA1402 [resolves #3803] Aug 3, 2024
@6bee 6bee force-pushed the fix/3803 branch 5 times, most recently from c4b4ac9 to 06ec4fb Compare August 30, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1402 Should not apply to file-scoped types
2 participants