Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu): 菜单组件 #516

Merged
merged 7 commits into from
Apr 19, 2022
Merged

feat(menu): 菜单组件 #516

merged 7 commits into from
Apr 19, 2022

Conversation

GaoNeng-wWw
Copy link
Collaborator

No description provided.

@kagol
Copy link
Member

kagol commented Apr 18, 2022

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：

pnpm build

@kagol
Copy link
Member

kagol commented Apr 18, 2022

命名上有两个需要优化的点：

  1. hooks改成composables，保持一致性
  2. 实际hooks的命名使用use开头，比如useMenu

@GaoNeng-wWw
Copy link
Collaborator Author

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：

pnpm build

本地运行pnpm build后报ReferenceError: location is not defined错误

@kagol
Copy link
Member

kagol commented Apr 18, 2022 •
edited
Loading

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：

pnpm build

本地运行pnpm build后报ReferenceError: location is not defined错误

你看下这个构建日志的信息哈~
https://github.com/DevCloudFE/vue-devui/runs/6060814179?check_suite_focus=true

我看报错信息是这个：

Could not resolve '../types/menu-item-type' from devui/menu/src/components/menu-item.tsx

@GaoNeng-wWw GaoNeng-wWw reopened this Apr 18, 2022
@kagol kagol added the feature New feature label Apr 19, 2022
@kagol kagol merged commit c4f281e into DevCloudFE:dev Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kagol kagol kagol approved these changes

Assignees
No one assigned
Labels
feature New feature PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaoNeng-wWw @kagol