Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Bundle libomp140.x86_64.dll with the binary #86

Closed
Derpius opened this issue Sep 25, 2022 · 0 comments
Closed

[bug] Bundle libomp140.x86_64.dll with the binary #86

Derpius opened this issue Sep 25, 2022 · 0 comments
Labels
binary module Issues relating to the binary module bug Something isn't working high priority
Milestone

Comments

@Derpius
Copy link
Owner

Derpius commented Sep 25, 2022

Describe the bug
OpenMP actually depends on this runtime DLL which seems to be specific to Visual Studio 2019 (2022 too?), causing the module to fail to load on any system that doesn't happen to have the binary.

Solution is to just bundle my copy of the DLL with releases and artefacts. However, this means users will need to place the binary in their GarrysMod directory, complicating the install.

To mitigate this I could generate separate with and without OpenMP builds, although if someone can't drag and drop a DLL to GarrysMod they probably wouldn't be using this in the first place

@Derpius Derpius added bug Something isn't working high priority binary module Issues relating to the binary module labels Sep 25, 2022
@Derpius Derpius added this to the v0.13.0 milestone Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary module Issues relating to the binary module bug Something isn't working high priority
Projects
Status: Done
Development

No branches or pull requests

1 participant