Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(@vtmn/css): display issue for the vtmn-select_container when the text are too long #1473

Open
LionelSpanneut opened this issue Nov 13, 2023 · 0 comments
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages

Comments

@LionelSpanneut
Copy link

LionelSpanneut commented Nov 13, 2023

Actual behavior

I am a developper in Myaccount Team, we have seen issues with the select (.vtmn-select_container).

  1. The label is displayed only in one line but it is problematic for long translations for example. See the screenshot :
    image
    image

  2. the option inside the select is too long and the display of the select goes out the window
    image

Expected behavior

  1. allow a long label in multiples lines.
    image

  2. fix the display of the select when the option text is too long
    image

To fix the issues, I have made this modifications in my code

  • add a container around the select
    image

  • overwrite the following css
    image

The code of the ::before is the same as .vtmn-select_container::before except the position, float and inset-block-start

Version affected
"@vtmn/css": "^0.91.5",

You can contact me or Myaccount Team if you have any questions.

Thanks
Lionel

@LionelSpanneut LionelSpanneut added the bug 🐛 Something isn't working label Nov 13, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community label Nov 15, 2023
@lauthieb lauthieb changed the title bug: Display issue for the vtmn-select_container when the text are too long bug(@vtmn/css): Display issue for the vtmn-select_container when the text are too long Nov 15, 2023
@lauthieb lauthieb changed the title bug(@vtmn/css): Display issue for the vtmn-select_container when the text are too long bug(@vtmn/css): display issue for the vtmn-select_container when the text are too long Nov 15, 2023
@lauthieb lauthieb added the CSS 🎨 Related to CSS styles packages label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages
Projects
None yet
Development

No branches or pull requests

2 participants