contrib/cloud.google.com/go/pubsub.v1: Add WithServiceName option #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gbbr Thanks for the review. Please take another look. |
gbbr
reviewed
Oct 8, 2020
mickeyreiss
force-pushed
the
service-name
branch
from
be94264
to
021ae26
Compare
|
@gbbr I addressed your comments and rebased against the |
|
Contrib test failures are unrelated to this patch. They were fixed in #761 |
|
Is this blocked? |
knusbaum
previously approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Hi, @mickeyreiss.
This is not blocked, I just haven't upmerged it yet to get the contrib tests to pass, so it has not been merged.
It is still approved and marked to go in as part of the 1.28.0 release.
If you would like to upmerge feel free, otherwise I will do so sometime before the 1.28.0 release.
mickeyreiss
force-pushed
the
service-name
branch
from
021ae26
to
d6223c8
Compare
knusbaum
approved these changes
Dec 1, 2020
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new options parameter, as well as a new option for
WrapReceiveHandler, so that GCP pubsub receivers can set a custom service name for their traces.This PR also introduces an options pattern for this library, so that other options can be added in the future.
For the unit test, I was somewhat lazy, in that I simply copied the existing test and modified it to utilize the new option.
This solution will work for my use-case, but it won't be sufficient in case the pubsub receiver is started in the context of another trace. I don't think it is common to set up new receivers dynamically, but I did want to call that out as a limitation to this solution.
Feel free to leave code review notes or make commits to this branch directly. Thanks!
Fixes #752.
cc/ #721 @CAFxX @knusbaum @gbbr