Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galacticraft Sealed Space Block additions #2764

Closed
keraldi opened this issue Jun 5, 2018 · 11 comments
Closed

Galacticraft Sealed Space Block additions #2764

keraldi opened this issue Jun 5, 2018 · 11 comments

Comments

@keraldi
Copy link
Contributor

keraldi commented Jun 5, 2018

Context

Galacticraft is supposed to add modifications of the Glass block as oxygen sealing blocks for the Oxygen Sealer (machine needed to fill rooms in space with oxygen). Chisel and Tinker's Construct glass blocks however are not detected automatically (all solid blocks count as sealing by default, Galacticraft tries to find glass-type blocks to add them to the list).
The Galacticraft Wiki mentions Tinker's Glass as example for a possibly wanted oxygen sealable block that is not detected automatically.

As a more personal note, Tinker's Construct Clear Glass is amongst the least-invading of all glass types and my favorite glass type for all glass buildings, especially glass domes/cubes. When using a Celestial Gateway for inter dimensional transport, an encasement made of Clear Glass also allows for the full beauty of the Celestial Gateway structure on minimal space.

A Clear Glass encasement is the perfect habitat for test subjects as they will feel like they are not imprisoned at all.

Also please remove Glass panes from the list, they even count if used in the ceiling/floor.

For the time being, the following near-invisible glass types work
  • AE2 Quartz Glass & Vibrand Quartz Glass
  • PneumaticCraft Pressure Chamber Glass

Config/Script Details

@artdude543
Copy link
Contributor

Am I presuming you have tested the config change?

@keraldi
Copy link
Contributor Author

keraldi commented Jun 5, 2018

I actually have not yet, will do tomorrow.
Format is consistent with the how to on the Galacticraft wiki though.

@keraldi
Copy link
Contributor Author

keraldi commented Jun 6, 2018

I take it back, didn't have a lot of time 8 hours ago, I'll get back to it later today (in a couple hours), look for the error and do some elaborate testing.

EDIT: testing now, will comment behind config entry whether or not it works, then try to add them via ID (Galacticraft is supposed to tell you the block name then).

@keraldi
Copy link
Contributor Author

keraldi commented Jun 6, 2018

2018-06-06_18 53 47
From left to right:

  • PneumaticCraft Pressure Chamber Glass (Sealed)
  • Primal Core Soul Glass (Sealed)
  • Tconstruct Seared Glass (Not Sealed)
  • Natura Heat Glass (Not Sealed)
  • Natura Soul Glass (Not Sealed)
  • Ferdinant's Flowered Dyed Glass (red) (Not Sealed) (Assuming it doesn't work for any color (different Meta IDs)
  • Mekanism Structural Glass (Not Sealed)
  • Chisel Red Stained Glass (Panel) (Not Sealed) (Assuming it doesn't work for any color (different name) or texture (different Meta IDs)
  • Tconstruct Clear Glass (Sealed)
  • Tconstruct Clear Light Grey Stained Glass (Not Sealed) (Assuming it doesn't work for any color (different Meta ID's)
  • Actually Additions Greenhouse Glass (Sealed)
  • Immersive Engineering Insulating Glass (Not Sealed)

The Not Sealed entries consist of:

  • All glass types that have Meta ID (Mekanism Structured Glass, IE Insulating Glass, Natura Heat & Soul Glass, colored glass types, texture variating glass types (Chisel))

And, additionally, Tconstruct Seared Glass.

My guess: I forgot to add Seared Glass and all glass types with Meta ID don't work/syntax wrong (because I had to enter specific ID's for Insulating Glass and Structured Glass. Double-checking and testing again now, result expected within the next hour.

EDIT: very certain now that it has something to do with Meta IDs (found a typo in the Seared Glass entry), however according to the Galacticraft wiki, the syntax should be right.

Will give another update in an hour or so.

After looking at the launcher log, it seems that the config doesn't like inline comments, which is why Insulating Glass and Structural Glass weren't recognized. Furthermore, asterix doesn't seem to be supported anymore. I'll just add everything by hand which should fix it all.

@keraldi
Copy link
Contributor Author

keraldi commented Jun 6, 2018

Updated the gist, testing it now but I changed all... irregularities.

EDIT: It works.

EDIT2: Forgot chisel:glassdyedred and chisel:glassdyedgreen, added them now... I think I got them all. I'm done.

@artdude543
Copy link
Contributor

Sweet thanks. I'll test it after work and merge it into the pack! Thanks for your work on this!

@artdude543
Copy link
Contributor

Okay, so some stuff errors in the console which is fine. But we need to fix them for the next update. And go over it in more detail.

I did a speed check over and missed the console errors so my bad but we're pushing 3.0.8 now so will be left behind

@artdude543 artdude543 reopened this Jun 8, 2018
@keraldi
Copy link
Contributor Author

keraldi commented Jun 9, 2018

Typo in mod name: ferdinandsflowers (I spelled it ferdinantsflowers) it's fixed now.

@artdude543 artdude543 modified the milestones: 3.0.9, 3.1.0 Jul 21, 2018
@valrosss
Copy link

is is possible to add RF tools Shield Blocks?

@keraldi
Copy link
Contributor Author

keraldi commented Jul 31, 2018

Yes, if you can give me the ID. (Modname:blockname:meta)

@artdude543
Copy link
Contributor

Going to close this one now. As we've added the main blocks. And I'm not happy to add RF Shields to the listing. You're forced to either use GC methods or build a base. Not cheat with a "magical" shield.

😄

@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants