Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice to use CustomName or Lore #198

Closed
UnknownOre opened this issue Mar 7, 2019 · 6 comments
Closed

Choice to use CustomName or Lore #198

UnknownOre opened this issue Mar 7, 2019 · 6 comments

Comments

@UnknownOre
Copy link

Please make sure your issue complies with these guidelines:

    • Server Software must be the official PMMP w/o vanilla patching plugins (i.e. TeaSpoon)
    • Issue must have not been reported previously
    • Make sure you are on the latest version of PMMP & PiggyCustomEnchants
    • Have a detailed title, like "CustomEnchants::getName() must be..."
    • If possible, provide crashdumps/errors related to the issue.

General

The Custom Enchantment not showing in item Lore

Version:

PiggyCustomEnchants version 1.4.3
Author: DaPigGuy

  • PMMP:
    PocketMine-MP 3.6.1 for Minecraft: Bedrock Edition v1.9.0 (protocol version 332

Steps to Reproduce the Issue

  1. hold an item
    2./ce enchant LifeSteal 1

Extra Information

@Aericio
Copy link
Sponsor Collaborator

Aericio commented Mar 8, 2019

Update PMMP to 3.6.3 and try again. It is working for me.

@UnknownOre
Copy link
Author

Update PMMP to 3.6.3 and try again. It is working for me.

ok

@UnknownOre
Copy link
Author

https://youtu.be/MBXS0gQ03NM on version 3.6.4

@Aericio
Copy link
Sponsor Collaborator

Aericio commented Mar 9, 2019

You won't see it on the popup, but you will see it in the inventory. You won't get the enchant names shown there anymore because we are using lore instead, and that doesn't show on popup. I might add an option to choose whether to use custom name or lore.

@Aericio Aericio changed the title Enchantment name not showing in item Lore Choice to use CustomName or Lore Mar 9, 2019
@Aericio
Copy link
Sponsor Collaborator

Aericio commented Mar 16, 2019

I haven't tested it yet, but it should work. Please tell me if there are any issues.

@Aericio
Copy link
Sponsor Collaborator

Aericio commented Mar 17, 2019

@ComboLordC Unrelated to this issue.

Also, modifying the code yourself is not my problem. If you don't know what you are doing, then don't edit the plugin. I can't provide any help either if you only say "i edit code and it doesn't work."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants