Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in support for TextWriter implementations #49

Closed
lahma opened this issue Apr 23, 2021 · 7 comments · Fixed by #50
Closed

Built-in support for TextWriter implementations #49

lahma opened this issue Apr 23, 2021 · 7 comments · Fixed by #50

Comments

@lahma
Copy link
Contributor

lahma commented Apr 23, 2021

Currently you cannot directly use StringWriter with ZString as StringWriter accepts regular StringBuilder. I created helper ZStringWriter for Orchard Core. Would it make sense to offer ZStringWriter (UTF-16) and Utf8ZStringWriter out of the box?

If you think it's a viable option I could offer a PR, just tell me desired names for the classes and namespace.

@neuecc
Copy link
Member

neuecc commented Apr 23, 2021

ZStringWriter for StringWriter, I think it's a good and intuitive name.
The implementation is also good, I hadn't thought of that idea.

If you give me a PR, I would love to accept it.
I think we should keep the name as proposed and use the top-level namespace (Cysharp.Text).

@lahma lahma mentioned this issue Apr 23, 2021
@lahma
Copy link
Contributor Author

lahma commented Apr 23, 2021

Here's the PR for basic implementation, maybe can be improved further if specific uses and overloads are needed #50 .

@lahma
Copy link
Contributor Author

lahma commented Apr 28, 2021

@neuecc Have you happened to have time to have a glimpse at the PR? I'd love to improve if needed.

@neuecc
Copy link
Member

neuecc commented Apr 29, 2021

Sorry, I've focused to release new library MessagePipe.
I've done most of it, so yes, I'll Merge the PR first, since it's unlikely to cause breaking changes in later expansions.

@lahma
Copy link
Contributor Author

lahma commented Apr 29, 2021

Thanks for accepting the PR. Your new library looks awesome, you seem to have great productivity! Eagerly waiting for release bits 😉

@neuecc
Copy link
Member

neuecc commented Apr 30, 2021

I've released (2.4.2) and add description to ReadMe.
Thanks!

@lahma
Copy link
Contributor Author

lahma commented Apr 30, 2021

Thank you for being so reactive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants