Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to specify "user defined gamma" #45

Open
3 tasks
nocotan opened this issue Dec 28, 2020 · 0 comments
Open
3 tasks

Enable to specify "user defined gamma" #45

nocotan opened this issue Dec 28, 2020 · 0 comments

Comments

@nocotan
Copy link
Member

nocotan commented Dec 28, 2020

Summary

Currently, udf_gamma is always 1.
However, it should be specified by users.

Then, I think it is better to modify the argument cardinality as follows:

assert (cardinality in ["one", "reciprocal", "udf_gamma"]) or isinstance(cardinality, float)

Goal

Modify udf_gamma.

Todo

  • rewrite init functions of the TimeSeriesPrecision and TimeSeriesRecall.
  • rewrite gamma_function/gamma_select
  • delete udf_gamma() function

Deadline

yyyy / mm / dd

Parent issue

If the parent issue exists, post a link here.

References

If there are any reference links, they are described here.

Notes

Other comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant