Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and dependencies for Azure DevOps provider #265

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

szecsip
Copy link
Contributor

@szecsip szecsip commented Aug 31, 2023

This PR encompass two critical aspects: documentation improvements and Python requirement specifications about Azure DevOps provider. These enhancements aim to streamline the integration process and ensure seamless functioning of the Azure DevOps provider.

@mrT23
Copy link
Collaborator

mrT23 commented Aug 31, 2023

I am hesitant about adding the azure packages to requirements.txt

The requirements file is getting bigger and bigger, while most people probably won't use these specific packages

@okotek any thoughts about this ? do you know a way to enable people do install packages on-demand, instead by default ?

@szecsip
Copy link
Contributor Author

szecsip commented Aug 31, 2023

I am hesitant about adding the azure packages to requirements.txt

The requirements file is getting bigger and bigger, while most people probably won't use these specific packages

@okotek any thoughts about this ? do you know a way to enable people do install packages on-demand, instead by default ?

I think in the future we have to create pip installable package, and control (all) providers dependencies install like pip install pr-agent[azure]. (for example with pyproject project.optional-dependencies configuration)

@mrT23 mrT23 merged commit 1b780c0 into Codium-ai:main Sep 1, 2023
2 checks passed
yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
Add docs and dependencies for Azure DevOps provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants